refactor(questions): type questions with TypedDict#1485
Merged
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom Jun 8, 2025
Merged
refactor(questions): type questions with TypedDict#1485Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
Conversation
bearomorphism
commented
May 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1485 +/- ##
=============================================
+ Coverage 97.87% 97.88% +0.01%
=============================================
Files 57 58 +1
Lines 2677 2700 +23
=============================================
+ Hits 2620 2643 +23
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
Jun 8, 2025
Lee-W
reviewed
Jun 8, 2025
|
|
||
| # Type | ||
| Questions = Iterable[MutableMapping[str, Any]] | ||
| Questions = Iterable[MutableMapping[str, Any]] # TODO: deprecate this? |
Lee-W
approved these changes
Jun 8, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Mostly good; respond to one of your questions. Let me know if you want to address it in this PR or the next. Thanks!
Lee-W
added
pr-status: ready-to-merge
Lee-W
force-pushed
the
refactors
branch
2 times, most recently
from
baee83e to
a9cd957
Compare
bearomorphism
force-pushed
the
typed-questions
branch
from
0a2c7b3 to
f18342b
Compare
This was referenced Jun 8, 2025
Lee-W
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A better version of #1467
Make the type of questions more strict. Not sure whether we should deprecate the type
Questions.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context